Repository navigation
Fix epoch attributes with wrong type - #3581
Merged
leowerneck merged 2 commits intoOct 21, 2026
Merged
leowerneck merged 2 commits into
leowerneck merged 2 commits into
Conversation
leowerneck
added
Ins: CoDICE
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The upstream release confirms the fix, and the regression test covers both required attribute types with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes #3579 by adopting the upstream correction for epoch attribute types in generated CDF products.
Changes:
- Raises the minimum and locked
cdflibversion to 1.3.15. - Adds regression coverage confirming epoch attributes use TT2000 while epoch-delta attributes remain INT8.
| File | Description |
|---|---|
| pyproject.toml | Requires cdflib>=1.3.15. |
| poetry.lock | Updates the locked version, package hashes, and content hash. |
| imap_processing/tests/cdf/test_utils.py | Checks written epoch and epoch-delta attribute types. |
Review effort: Balanced
leowerneck
requested review from
bryan-harter,
jaredclaypoole,
lacoak21,
tech3371,
tmplummer and
vineetbansal
October 21, 2026 14:09
bryan-harter
approved these changes
Oct 21, 2026
leowerneck
merged commit Oct 21, 2026
b1ae067
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #3579.
Overview
This PR bumps
cdflibto version 1.3.15, required to fix #3579, as described in lasp/cdflib#348 and lasp/cdflib#349.File changes
pyproject.toml: bumped CDF lib to 1.3.15.poetry.lock: bumped CDF lib to 1.3.15.imap_processing/tests/cdf/test_utils.py: add regression test.Testing
Running:
results in 1841 passed tests and no failures.